Cache provider IDs for single Emby item updates #63
Conversation
…g-for-various-edit-operations-in-emby.py-q7oshl
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
modules/emby.py
Outdated
| k: v | ||
| for k, v in entry.get("provider_ids", {}).items() | ||
| if k.lower() != self.EmbyServer.CUSTOM_RATING_PROVIDER.lower() | ||
| } | ||
| entry["update"][item_field] = filtered_ids |
There was a problem hiding this comment.
User rating removal leaves CustomRating intact
For userRating remove/reset batches the code builds filtered_ids without the CustomRating provider and stores it in update (lines 786-790), but EmbyServer.__update_item merges provider IDs instead of replacing them, so omitting CustomRating never deletes the existing value. As a result any userRating remove/reset (including episode edits) will silently leave the prior custom rating on the item instead of clearing it.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task