Ensure Emby overlays pull custom ratings from provider IDs #65
Conversation
61698bc
into
nightly_feature_emby_overlays_2
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "Overlay Warning: Emby custom ratings must be provided via " | ||
| "ProviderIds['CustomRating']; the CustomRating field is ignored." | ||
| ) | ||
| if actual_value is None and hasattr(item, actual_attr): | ||
| actual_value = getattr(item, actual_attr) |
There was a problem hiding this comment.
Guard missing Emby user ratings to avoid runtime errors
When format_var == "user_rating" the new Emby-specific branch leaves actual_value as None when an item has no ProviderIds['CustomRating'] or userRating, then proceeds to the formatting block that calls float(actual_value) for mods like %, #, or / (see lines 535‑541). Unlike the previous path, this branch never raises Failed on a missing rating, so an unrated Emby item will now throw a TypeError during overlay rendering instead of being skipped with a warning, halting overlay processing for that library.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task