Moved the metadata into setup.cfg #497
Conversation
fbfe3af to
c060cb1
Compare
|
Travis CI build has failed because psutil has dropped pypy 2.7. Taking in account that python 2.7 is EOL, should we drop pypy 2.7 too or should we just apply a patch removing the antifeature from psutil? |
|
I'll try to fix the CI soon. Note from that link: I'm just giving up on a specific broken PyPy2 version which hopefully will be fixed soon. - looks like PyPy 2 support is not gone yet, just partially broken. Note that Python 3 support has been much slower in PyPI, with 3 being called beta support until recently. PyPy 2.7 is still very common. Hopefully will start to die out though now that main Python 2 is going out. Dropping PyPy 2.7 doesn't really bother me, honestly though. Plumbum needs to work out-of-the box on all systems, but no system has only PyPy (2.7). |
setup.py
Outdated
| platforms = ["POSIX", "Windows"], | ||
| provides = ["plumbum"], | ||
| keywords = "path, local, remote, ssh, shell, pipe, popen, process, execution, color, cli", | ||
| cmdclass = {'test':PyTest, |
There was a problem hiding this comment.
I'm okay with killing off 'test' and test_requires too, by the way (doesn't need to be in this PR); Python is deprecating setup.py test. The only correct way to run the tests is via pytest.
setup.cfg
Outdated
| plumbum.path | ||
| plumbum.fs | ||
| plumbum.colorlib | ||
| setup_requires = setuptools>=44; wheel; setuptools_scm[toml]>=3.4.3 |
There was a problem hiding this comment.
Please remove this line. setup_requires is deprecated.
There was a problem hiding this comment.
I don't think we should remove it (older versions of setuptools that don't know about pyproject.toml should understand that).
But as you wish, it's not a very strong issue, ones staying on bleeding edge (like me) should not encounter any issues from that.
There was a problem hiding this comment.
It turned out without this line builds fail.
There was a problem hiding this comment.
Okay. Should only affect building wheels, which only devs and CI does, but maybe we don’t have the CI up to date. It doesn’t hurt to have it.
da582bf to
f05ed83
Compare
|
Do what you feel is right. I am OK to wait until any next releases as long as it doesn't take long to wait. I mean not months and not years. IMHO it is OK to have 10 seconds between 2 releases :). |
da56998 to
fe4e96f
Compare
|
1.6.9 is out. Feel free to drop 2.6! |
|
Fantastic, thanks! Thanks also for cleaning out a few ugly 2.6 workarounds! |
No description provided.