iter_lines: added new 'buffer_size' parameter, and updated docstrings #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f0be6c to
a0aacc0
Compare
henryiii
reviewed
Jan 29, 2022
henryiii
approved these changes
Jan 29, 2022
There was a problem hiding this comment.
Seems fine. I think we should try to look as much like Python 3's subprocess, but this method is not one from subprocess AFAIK, so don't have strong opinions on adding a bit of functionality here. If my one tiny suggestion is fine, I think it's good to merge.
henryiii
reviewed
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.