made StdinDataRedirection compatible with modifiers writing to stdout #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_I.e._ fixed:
(cat << "meow") & FG
Modifiers writing to stdout -- _e.g._: FG, TEE, RETCODE(FG=True) and
TF(FG=True) -- invoke commands with the specification `stdin=None`.
This is handled correctly by BaseCommand; however, StdinDataRedirection
misinterprets this as a further attempt to specify stdin (_i.e._ to
specify _something_ rather than _nothing_).
This change brings StdinDataRedirection in line with its base class,
ignoring `None` as well as `PIPE`.
(Though a technical detail, the class would also have failed any
invocation setting `stdin=PIPE`, along the lines of: "TypeError: got
multiple values for keyword argument 'stdin'". The kwargs passed to the
wrapped command's `popen` are corrected as well.)
resolves tomerfiliba#604
Signed-off-by: Henry Schreiner <[email protected]>
|
Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. fixed:
Modifiers writing to stdout – e.g.:
FG,TEE,RETCODE(FG=True)andTF(FG=True)– invoke commands with the specificationstdin=None.This is handled correctly by
BaseCommand; however,StdinDataRedirectionmisinterprets this as a further attempt to specify stdin (i.e. to
specify something rather than nothing).
This change brings
StdinDataRedirectionin line with its base class,ignoring
Noneas well asPIPE.(Though a technical detail, the class would also have failed any
invocation setting
stdin=PIPE, along the lines of: "TypeError: gotmultiple values for keyword argument 'stdin'". The kwargs passed to the
wrapped command's
popenare corrected as well.)resolves #604