fix(throttle): preserve this context when called as method #1497
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the throttle function to properly preserve the this context when the throttled function is called as an object method. Previously, the this context was lost during invocation, which could cause issues when throttling methods that depend on their object context.
Key Changes
- Added explicit
this: anyparameter to the throttled function to capture the calling context - Changed invocation from direct call to
apply()to forward the captured context to the debounced function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/function/throttle.ts | Updated throttled function to preserve this context by adding explicit this parameter and using apply() for invocation |
| src/function/throttle.spec.ts | Added test case verifying that this context is correctly preserved when throttle is used as an object method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 468 468
Lines 4453 4453
Branches 1311 1311
=======================================
Hits 4448 4448
Misses 5 5 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.