-
Notifications
You must be signed in to change notification settings - Fork 41
Add BMI parameter to WeightScaleMsg #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @davidkroell. I cant't find this field (for the WeightScaleMsg) in the official FIT profile (21.60). Should it be there? |
|
Hi @tormoder, I don't know if this is officially supported within this message. I've got this from there: https://github.com/jaroslawhartman/withings-sync/blob/4e96d96364b848c4222354ac904c55c5053d97f9/withings_sync/fit.py#L203-L221 and tried it out with Garmin Connect and it works. |
|
This repository uses the official SDK profile from Garmin (a sheet) to grenerate all code related to messages and fields. This means that we can't (and I don't want) to have any special handling of fields or message, since it will be overwritten when we generate code for a new profile. The only current exception is for errors in the profile sheet that causes code generation to fail. I can't see a BMI field for the But, since you are actively using this library, I would like to help you. I'll look into providing a separate branch for you. Give me a few days :-) |
|
Hi, I came across this topic here (in search of a BMI synchronization solution): There are other interesting fields (in search of a Caloric Intake synchronization solution): Best Regards, |
|
Thanks for the input @RobertWojtowicz. It seems to me, based on jaroslawhartman/withings-garmin-v2#16, #6 is somewhat related. The other two fields you mention is documented and enabled in the last (21.67) default profile: |
|
Hi, @tormoder Are you planning to add that BMI field ? |
|
@davidkroell You can temporarily use the
|
|
Hi, @davidkroell can you create a new version bodycomposition with BMI ? Best Regards, |
|
Hi guys, a new release is available here: https://github.com/davidkroell/bodycomposition/releases/tag/v2.2.0. @tormoder thanks for providing the branch. |
|
It works, thank you very much :) Only Caloric Intake is missing now (not working) |
|
Closing this, since this change now lives on a separate branch. Supporting it for the main branch must be done via something like #62. "Caloric Intake" can be added to the branch if that (hidden) field exsits and someone could provide the field definition. |
|
@davidkroell FYI, Line 4960 in 181a8ab
|
|
Hi, I know that the bodycomposition module is working well, but could you refresh it at your free time? based on the new versions of the libraries and include the master branch termoder? BR, |
|
@RobertWojtowicz working on it. Next time please open a issue at my repo instead (I've done it now for you). |
Hi @tormoder,
I'd like to add the BMI parameter to the WeightScaleMsg, due to the issue here: davidkroell/bodycomposition#9
I've conducted a first integration test with my utility davidkroell/bodycomposition and it works:
(screenshot from Garmin Connect)
I wasn't able to fix the tests, could you help me out?
Regards,
David