feat(fish): add glab-new-pr completion and config #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds configuration support and a completion script for the glab-new-pr alias to enhance GitLab merge request functionality via the fish shell.
- Adds a new fish completion configuration block in nix/hm/fish.nix.
- Introduces a new fish completion script in conf/fish/shellcompl/glab-new-pr.fish.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nix/hm/fish.nix | Adds configuration for enabling fish completions from a new source. |
| conf/fish/shellcompl/glab-new-pr.fish | Implements a fish completion script for the glab-new-pr alias. |
Comments suppressed due to low confidence (1)
nix/hm/fish.nix:66
- Consider adding a brief inline comment to explain the purpose of the fishCompletions configuration block for future maintainers.
home.file.fishCompletions = {
Comment on lines
+4
to
+5
| # Complete with git branches (local and remote) sorted by commit date | ||
| complete -c glab-new-pr -f -a '(git branch -a --sort=-committerdate 2>/dev/null | string replace -r "^\s*[\*\+]?\s*" "" | string replace -r "^remotes/[^/]+/" "" | awk "!seen[\$0]++" 2>/dev/null)' -d "Create GitLab merge request for branch" |
There was a problem hiding this comment.
[nitpick] Consider refactoring the complex piped command into a separate helper script or adding detailed inline comments to enhance readability and future maintainability.
Suggested change
| # Complete with git branches (local and remote) sorted by commit date | |
| complete -c glab-new-pr -f -a '(git branch -a --sort=-committerdate 2>/dev/null | string replace -r "^\s*[\*\+]?\s*" "" | string replace -r "^remotes/[^/]+/" "" | awk "!seen[\$0]++" 2>/dev/null)' -d "Create GitLab merge request for branch" | |
| # Helper function to get git branches (local and remote) sorted by commit date | |
| function __get_git_branches | |
| # List all branches (local and remote) sorted by committer date | |
| git branch -a --sort=-committerdate 2>/dev/null | | |
| # Remove leading symbols (*, +) and whitespace | |
| string replace -r "^\s*[\*\+]?\s*" "" | | |
| # Remove remote prefixes (e.g., "remotes/origin/") | |
| string replace -r "^remotes/[^/]+/" "" | | |
| # Deduplicate branch names | |
| awk "!seen[\$0]++" 2>/dev/null | |
| end | |
| # Complete with git branches (local and remote) sorted by commit date | |
| complete -c glab-new-pr -f -a '(__get_git_branches)' -d "Create GitLab merge request for branch" |
The commit adds detailed API design and function signature guidelines to the prompt generation documentation, including anti-patterns to avoid and best practices for clear function contracts.
58ccaf9 to
235f7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.