fix: update task plan paths to remove leading dot #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates task plan directory paths by removing the leading dot, so that the paths are now specified without the dot prefix.
- Update directory creation and output file path in the script
- Update documentation in the prompt configuration file to reflect the new directory path
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nix/hm/ai.nix | Removed the leading dot from the task plan directory name. |
| conf/llm/aichat/roles/gen-prompt.md | Updated instructions to refer to the file output directory without the leading dot. |
Comments suppressed due to low confidence (2)
nix/hm/ai.nix:28
- There is an inconsistency in the directory naming: the script creates 'llm/task-plan-prompts', while the documentation refers to 'llm/task-plans'. Consider aligning the directory name across both files.
mkdir -p llm/task-plan-prompts
conf/llm/aichat/roles/gen-prompt.md:11
- Ensure that the directory naming for task plans is consistent with the script; update the documentation to match 'llm/task-plan-prompts' or modify the script to use 'llm/task-plans'.
The prompt you generate should instruct the agent to write the task plan in a markdown file in working directory at `llm/task-plans/`.
PR Summary
|
Add detailed step-by-step logging to AI commit script with progress indicators and error handling. Include clear step numbering and success/failure markers.
- Simplify jj-ai-commit.sh by removing redundant code - Enhance jj-commit-context.sh with improved git context gathering - Update git-commit.md role documentation with clearer rules - Adjust nix configuration for script changes Review notes: - Good consolidation of script functionality - Documentation updates help maintain consistency - Consider adding error handling in bash scripts
…ation - Added explicit requirements for preserving specific implementation details - Expanded context extraction guidelines with concrete examples - Added mandatory sections for implementation requirements in templates - Strengthened prompt writing guidelines with critical success factors Review notes: - Good focus on preserving implementation-critical details - Clearer structure for capturing user-provided information - Consider adding examples of well-preserved details in future updates
Add comprehensive bash script to configure AI-assisted git commit workflow. Includes environment setup, dependency checks, and git hook configuration. Review notes: - Consider breaking into smaller functions for maintainability - Add error handling for missing dependencies - Document required environment variables
Remove markdown formatting from examples and explicitly state raw text output requirement Update examples to demonstrate plain text format without code blocks
Review notes: - Prevents redundant downloads when file already exists - Good use of return code (0) for success case - Consider adding timestamp check for version updates in future
Review notes: - Good addition for improved git rebase workflow - Consider adding a note about the tool's installation requirements - Configuration matches well with existing git setup
Review notes: - Expanded review feedback section with more specific criteria - Reorganized example feedback to prioritize bug discovery - Added explicit guidance on when to include style feedback - Improved consistency in feedback format examples - No bugs found in existing documentation structure - Consider adding examples for security-related feedback
Review notes: - Removed obsolete bash version checking and installation functions - Code was checking for readarray support which is no longer needed - Cleanup reduces script complexity and maintenance burden - No functionality was lost as these checks were redundant - Script is now more focused on its core purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.