-
Notifications
You must be signed in to change notification settings - Fork 0
fix(fish): add --ignore-working-copy flag to jj bookmark list #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review notes: - Change prevents potential conflicts with working copy state - No bugs found in the modification - Maintains existing functionality while improving robustness - Good practice to ignore working copy for bookmark operations
…g-copy flags Review notes: - Good separation of concerns by splitting into _fzf-jj-bookmarks-jj and _fzf-jj-bookmarks-git - Consistent use of --ignore-working-copy flag across all jj commands - Clear error handling with return codes in helper functions - Consider adding comments explaining the priority order in main function - No bugs found in the refactored logic - Good backward compatibility maintained with existing behavior
Review notes: - Improved logic flow by early returning when not in git/jj repo - Better status handling by storing fzf status in variable - More consistent return behavior between git and jj functions - No bugs found in the refactored logic - Consider adding error handling for command failures - Recommend adding comments explaining the status handling logic
Review notes: - Significant improvements to directory context documentation - Clearer guidance on working vs target directory distinction - Added critical validation steps for directory navigation - Improved tool recommendations (fd/rg over grep/find) - Better organization of mandatory analysis steps - No bugs found in the documentation updates - Consider adding examples for each technology-specific directory requirement - Might want to add troubleshooting section for common directory context errors
Review notes: - Cleaner alias structure with reduced redundancy - Renamed 'mcon' to more descriptive 'split-on' - Consolidated squash operations under 'sq' alias - No functional changes detected - Consider adding comments explaining complex aliases
Review notes: - Good consolidation of duplicate functionality from jj-fork-main.fish and jj-fork-master.fish into jj-fork.fish - Clean removal of redundant files - Consider adding comments explaining the fork command behavior - Verify all git branch operations work as expected after refactor - Nix configuration update matches the new file structure
Review notes: - Script properly implements error handling with set -euo pipefail - Good separation of pipeline components into variables - Consider adding logging for debugging purposes - Missing error handling for aichat command failure - Recommend adding validation for script dependencies - Good practice to include script usage documentation in header
Changed terminal theme from dracula to builtin pastel variants and increased font size from 16 to 17.
0fc94ff to
c4d6dd6
Compare
Added new Model Context Protocol (MCP) configurations including Context7, server-memory, playwright, deepwiki, filesystem, github, and brave-search integrations. Also added private keys documentation file. Review notes: - Configurations appear properly structured with required parameters - Consider adding descriptions for all MCP services for better maintainability - Ensure all sensitive keys (GITHUB_PERSONAL_ACCESS_TOKEN, BRAVE_API_KEY) are properly secured - Verify timeout values (300ms) are appropriate for each service - Consider adding validation for required environment variables
f3edf17 to
08671bb
Compare
- Switch elixir version management to asdf - Add asdf path configuration to fish shell - Clean up fish function formatting Review notes: - No bugs found in the configuration changes - Good move to asdf for version management - Fish shell path handling is implemented correctly - Consider adding comments explaining the asdf setup rationale - Recommend verifying asdf plugin installation in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review notes: