-
Notifications
You must be signed in to change notification settings - Fork 0
fix: unset TMUX env in VSCode and Zed terminals #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review notes: - This change correctly addresses the issue of `fzf --tmux` hanging in VSCode and Zed terminals by unsetting the `TMUX` environment variable. - The conditional check for `$TERM_PROGRAM` is appropriate for identifying these specific environments. - This fix improves the user experience when using `fzf` within these integrated terminals.
PR Summary
|
Flake lock file updates:
• Updated input 'jj-repo':
'git+ssh://[email protected]/pze/jj.git?ref=refs/heads/main&rev=0a9ab49dc5e59d9d6032477d0f4e916a24c1ca21&shallow=1' (2025-06-13)
→ 'git+ssh://[email protected]/pze/jj.git?ref=refs/heads/main&rev=bc83eb0a4837bdec89792967dd28674141f4a364&shallow=1' (2025-06-23)
Allow `jj-fork` to automatically use the commit message of a specified revision as the description if no description is explicitly provided. This enhances usability by reducing the need for manual input when forking existing commits. Review notes: - The logic for fetching the commit message from `jj log` seems robust. - Error handling for cases where the commit message cannot be retrieved is in place. - The `tig` configuration changes are minor and seem to improve display without introducing issues. - Consider adding a test case for the `jj-fork` script to ensure the new description fallback works as expected.
8ff787c to
8312239
Compare
Review notes: - The diff indicates a near-complete rewrite of the `gen-prompt.md` file. - Ensure the new content accurately reflects the current prompt generation logic and requirements. - Verify that all necessary information from the previous version has been either incorporated or intentionally removed. - Consider if this extensive change warrants a more detailed commit message body explaining the rationale for the rewrite.
Review notes: - The diff indicates a significant rewrite of the gen-prompt.md file. - Ensure all critical information from the previous version is retained or intentionally removed. - Verify that the new content is clear, concise, and accurately reflects the current state of the AI chat roles. - Check for any broken links or outdated references introduced by the changes.
Refactor Goose LLM configuration to replace Notion with Anytype integration. Update `Justfile` to remove `--commit-lock-file` from `update-self-repo` command. Add `ANYTYPE_API_KEY` to Nix Home Manager AI configuration. Review notes: - The change from `notion` to `anytype` in the config file seems to be a direct replacement, ensuring the new integration is properly set up. - The `OPENAPI_MCP_HEADERS` environment variable is correctly configured to include the authorization token and Anytype version. - The `ANYTYPE_API_KEY` is correctly added to the Nix configuration, ensuring it's available for the Goose LLM. - The removal of `--commit-lock-file` from the `just update-self-repo` command is a minor change, but it's good to note. It means the lock file won't be automatically committed after updates, which might require manual handling if lock file changes are intended to be tracked.
Review notes: - The model name was updated from `claude-sonnet-4` to `claude-3.7-sonnet`. This is a minor version bump and should be compatible. - Ensure that the new model version `claude-3.7-sonnet` is indeed the correct and intended model to use, as `claude-sonnet-4` might refer to a different, potentially newer, internal alias or a future model. - Verify that this change does not negatively impact the prompt's performance or output quality.
Review notes: - The previous logic could leave temporary files in /tmp if the user aborted the editor without saving content. - The new approach ensures the temporary file is removed in both success and failure cases. - The temporary file is now stored in a dedicated directory with a timestamp, which is good for debugging if issues arise before deletion. - Consider using `mktemp -d` to create a temporary directory and then a file inside it, which might be cleaner for managing temporary resources.
e11e7fd to
548fd82
Compare
Add a detailed prompt for LLM-based task plan reviews, including review process, report format, and guidelines. Introduce a new `goose-review-plan` script to facilitate the review process. Review notes: - The prompt provides a comprehensive structure for task plan reviews, which should improve consistency and quality of LLM outputs. - The `goose-review-plan` script integrates well with the existing `goose` CLI, making the new functionality easily accessible. - Ensure the LLM is fine-tuned or capable enough to follow the detailed instructions and generate reports in the specified format. - Consider adding examples of good and bad task plans to the prompt for better context. - The script currently checks for argument count; ensure robust error handling for file existence and readability.
67258ec to
a0bb901
Compare
Review notes: - The change correctly addresses the issue of `interactive_mode` not being passed to `goose` when it's an empty string. - Using `set -l` and `eval` for command construction is a common pattern in fish shell for dynamic commands. - The previous single-line command was brittle and would fail if `$interactive_mode` was empty, as it would pass an empty string as an argument to `goose`. The new approach correctly omits the `--interactive` flag when `$interactive_mode` is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review notes:
fzf --tmuxhanging in VSCode and Zed terminals by unsetting theTMUXenvironment variable.$TERM_PROGRAMis appropriate for identifying these specific environments.fzfwithin these integrated terminals.