-
Notifications
You must be signed in to change notification settings - Fork 0
next #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
next #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
|
Add a new `yank-file` bash script that copies the content of a specified file to the system clipboard. The script automatically detects available clipboard utilities (pbcopy, xclip, xsel, wl-copy) and uses the first one found. Also, add the script to the Nix Home Manager configuration to make it executable and available in the user's path. Review notes: - The script handles various clipboard tools, making it portable across different desktop environments. - Error handling for missing files, unreadable files, and missing clipboard utilities is robust. - The `eval` command used for `cat '$file_path' | $clipboard_cmd` is generally safe here because `$clipboard_cmd` is derived from a fixed set of known commands and `$file_path` is quoted. However, in more complex scenarios, `eval` can be a security risk. For this specific use case, it's acceptable. - Consider adding a shebang to the `yank-file` script for direct execution. (Self-correction: The shebang `#!/usr/bin/env bash` is already present.)
7bf5784 to
2aba9ef
Compare
67f72e3 to
3aee19d
Compare
Add a new `elixir-issue.yaml` recipe for solving Elixir development problems. Introduce a `goose-role` script for running specific goose recipes. Update goose configuration to include StackOverflow tool and adjust model settings. Add Fish shell completion for `goose-role`. Review notes: - The `goose-role` script provides a convenient way to execute recipes. - The `elixir-issue.yaml` recipe seems well-defined for its purpose. - The new StackOverflow tool integration will enhance goose's capabilities. - `GOOSE_LEAD_FAILURE_THRESHOLD` reduced from 5 to 3, which might make goose more responsive to lead failures. - The change of `GOOSE_LEAD_MODEL` from `claude-3.7-sonnet` to `claude-sonnet-4` is a model upgrade, which should improve performance. - Ensure the `STACKOVERFLOW_API_KEY` is properly handled and secured in the environment.
d2e5174 to
22bca0c
Compare
Review notes: - This is a good addition for clarity in multi-model environments. - Ensures consistency in LLM responses.
22bca0c to
6635ffd
Compare
Adds argument parsing to the `ai-ci` alias to support a `-m` flag. This allows passing additional context directly to the AI model when generating a commit message. Review notes: - The argument parsing logic using a `while` loop and `case` statement is robust and standard for shell scripts. - Good error handling has been added for incorrect usage, such as a missing argument for `-m` or unexpected arguments. - The change correctly handles both the optional `-m` flag and the optional revision argument. No bugs found.
Review notes: - Changed model from 'google/gemini-2.5-pro' to 'mistralai/devstral-small' - Adjusted temperature from 0.9 to 0.2 and top_p from 0.9 to 0.8 - Ensure these changes align with desired AI behavior and performance
Review notes: - Configuration changes appear to be focused on adjusting model parameters - Temperature values have been reduced across multiple configurations - Model selection has changed in git-branch role - Ensure these changes are tested to verify they produce the desired behavior - Consider adding comments to explain the rationale behind parameter changes
Review notes: - Temperature and top_p values adjusted in multiple LLM role configurations - Changes appear to be parameter tuning for different models - Ensure these changes are tested to verify desired behavior - Consider documenting the rationale behind these parameter changes
Review notes: - The removed rule was redundant as it's already covered by the model's core behavior - No functional changes, only documentation update - Ensure all other documentation is consistent with this change
11665d3 to
dc181b3
Compare
Review notes: - Ensure that the new model is compatible with existing functionality - Consider documenting the reason for the model change for future reference
dc181b3 to
97a2725
Compare
Review notes: - The addition of rsync is straightforward and enhances the shared environment. - Ensure that rsync is necessary for all users of this configuration to avoid unnecessary bloat.
Review notes: - The new merge command enhances functionality for branch merging - Ensure that the merge message is customizable for better context - Consider adding error handling for merge conflicts in future updates
Review notes: - Ensure that the new model is compatible with existing configurations - Consider documenting the change in the project README or relevant documentation for clarity
Add configuration for MasterGo design collaboration tool in the goose config file. Update flake.lock with new dependencies and modify ai.nix to include MASTERGO_TOKEN. Review notes: - Ensure that the MASTERGO_TOKEN is securely managed and not exposed in the codebase - Consider adding documentation for the new MasterGo configuration to assist future developers - Verify that the new configuration does not conflict with existing tools in the goose setup
Refactor Nix files to enhance build efficiency and maintainability. Consolidate configurations and remove deprecated settings. Review notes: - Ensure that all changes in `ai.nix` and `helix.nix` are thoroughly tested, as they involve significant modifications. - Consider documenting the rationale behind major changes in the configuration files for future reference. - Verify that the new configurations do not introduce any compatibility issues with existing setups.
Update ai-br-error.md with a detailed error message related to invalid bookmark syntax in the version control system. Review notes: - The new documentation provides clear guidance on the error encountered, which is helpful for users. - Consider adding examples of correct bookmark syntax to further assist users in avoiding this issue. - Ensure that the link to the help documentation is up-to-date and accessible.
e3c7ebf to
b0f8c8d
Compare
Review notes: - The `flake.lock` update seems to be a side effect of other changes, likely due to `jj` repository update. - The `jj.nix` changes remove `push-bookmark-prefix` and add `git_push_bookmark` which is a refactor of how push bookmarks are handled in `jj`. This is a good improvement for flexibility. - The `fish.nix` change adds a new alias for "windsurf". This is a straightforward addition. - No bugs or critical issues found. The changes are consistent with typical configuration updates.
Review notes: - The `jj-fork.fish` script now correctly extracts only the first line of the commit message for the description, improving clarity. - The AI branch naming role has been refined by adjusting `temperature` and `top_p` for more consistent and focused output. - The example branch name format in the AI role was simplified by removing unnecessary markdown code blocks, which could have caused parsing issues. - The instruction "只返回一个分支名称,不要包含任何解释或其他文本以及换行符号" was added to the AI role, which is crucial for ensuring the AI provides a clean, single-line output. This directly addresses a potential bug where the AI might include extra text or newlines, breaking automation.
a40d23a to
de3beed
Compare
Review notes: - The changes consistently promote the use of modern tools like `fd` and `ripgrep` over `find` and `grep`, which is a good performance improvement for the LLM's search capabilities. - The updates clarify and reinforce existing rules, making the documentation more precise. - No bugs or logical errors introduced. The changes are purely documentation updates.
Remove `anytype`, `stackoverflow`, and `mcp-deepwiki` configurations from `conf/llm/goose/config.yaml` as they are no longer used. Disable `computercontroller` by default. Update `playwright` args to use `@playwright/mcp@latest`.
e5537f8 to
d4750a6
Compare
Add a new `ds-skip-ci` command to the `jj` configuration. This command allows users to prefix a commit's description with `[skip ci]` to prevent CI/CD pipelines from running on that commit. It handles cases where the prefix already exists and defaults to the current revision if none is provided.
e1e3a33 to
6cec600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(nix): add mcp-proxy to home-manager packages