docs: restructure coding rules with XML tags #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec25948 to
e803ac0
Compare
Reorganize coding rules documentation using XML-style tags for better organization and readability. Group related sections under appropriate semantic containers.
Reduce font size from 15 to 14 and comment out ctrl+l clear screen keybind.
5407492 to
b6f8ac0
Compare
Enable zellij terminal multiplexer configuration while disabling docker configuration in home-manager setup.
Add Nix Home Manager configuration for Cline AI assistant with global rules directory, proxy settings, and shell integration. Includes activation script for proper setup and permissions. Review notes: - No bugs found in configuration logic - Good use of Home Manager's activation system for directory setup - Consider making proxy settings configurable via environment variables - Shell integration for pager settings is well-implemented - Documentation for configuration options could be helpful
9746e5d to
a18b877
Compare
09c5400 to
63aacb3
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restructures and centralizes coding rules and agent instructions, introducing XML-style tags and templated injection across multiple tools (Claude, Codex, Windsurf, Cline). It also updates editor/tooling configs to align with new rules and narrows certain permissions and integrations.
- Switch Helix Nix LSP from nixd to nil; adjust packages/integrations across modules
- Introduce templated rules injection (@content@) for Windsurf/Cline; expand AI tool profiles and permissions
- Clean up Fish FIFC config; refine Claude/Codex MCP setups and documentation with XML-style tags
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| nix/home.nix | Adjusts packages/modules (remove nixd, add geist-font; enable zellij; disable docker) |
| nix/hm/helix.nix | Removes nixd, uses nil in Helix config; updates packages accordingly |
| nix/hm/fzf.nix | Enables Fish integration for fzf |
| nix/hm/fish.nix | Removes FIFC plugin and related shell configuration/bindings |
| nix/hm/ai/legacy.nix | Generates Windsurf global rules via template substitution and manages target file via home.file |
| nix/hm/ai/default.nix | Includes new Cline module |
| nix/hm/ai/codex/instructions/sage-role.md | Adds new “sage” role instructions with explicit output/behavior guidelines |
| nix/hm/ai/codex/default.nix | Updates Codex model/provider configs, profiles, and comments out certain MCP servers |
| nix/hm/ai/cline/default.nix | Adds Cline rule setup with template substitution and shell wrapper |
| nix/hm/ai/claude/settings.json | Refines permissions/tools; adjusts additionalDirectories |
| nix/hm/ai/claude/mcp.json | Removes/updates specific MCP servers and normalizes args formatting |
| nix/hm/ai/claude/default.nix | Updates kiro prompt with XML-style tags |
| nix/hm/ai/claude/assets/CLAUDE.md | Rewrites Claude rules with XML tags; clarifies tool usage/delegation |
| nix/hm/ai/claude/agents/oracle.md | Updates Oracle agent tools list |
| conf/llm/windsurf/workflows/muse.md | Removes workflow file |
| conf/llm/windsurf/workflows/kick-muse.md | Removes kick-off workflow file |
| conf/llm/windsurf/rules.md | Adds Windsurf rules template with @content@ placeholder |
| conf/llm/opencode/opencode.jsonc | Adjusts permissions and removes certain MCP servers |
| conf/llm/docs/coding-rules.md | Major rewrite of coding rules with structured sections and examples |
| conf/ghostty/config-default-keybind | Comments out ctrl+l clear_screen binding |
| conf/ghostty/config | Tweaks font size |
| .vscode/settings.json | Removes kiroAgent MCP setting |
| .trae/rules/project_rules.md | Removes project rules pointer |
| .claude/settings.local.json | Updates local Claude permissions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
6c2daaa to
7898278
Compare
Remove nixd configuration and replace with nil for Nix language server in Helix editor. Update dependencies across home-manager configuration.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Towry Wang <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Towry Wang <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Towry Wang <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Towry Wang <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Towry Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize coding rules documentation using XML-style tags for better
organization and readability. Group related sections under appropriate
semantic containers.