style(claude): format json array and remove output style setting #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faac7d8 to
5b47a4e
Compare
Review notes: - The lifeguard tool is disabled in eng.md but referenced in oracle.md for code review - this creates inconsistency in the agent delegation matrix - Model change from gpt-5 to gemini-2.5-pro in plan mode should be verified for compatibility - The reasoningEffort change from low to medium in eng.md may impact performance for quick tasks
f2fcdb6 to
b62c9c8
Compare
Review notes: - The COPILOT environment variable check logic appears inverted - it should enable starship when COPILOT is NOT set, but the condition `if not set -q COPILOT` will source starship when the variable doesn't exist 😢 - Consider using a more descriptive variable name than `COPILOT` to indicate its purpose - The manual fish integration in fish.nix conflicts with the disabled integration in starship.nix - this could cause unexpected behavior
dcacded to
2be6447
Compare
…ating Review notes: - Proxy port changed from 1080 to 7898 without explanation - verify this is intentional - Missing error handling for `builtins.readFile` on coding-rules.md could cause build failure if file doesn't exist 😢 - No validation that `mcpServers.clients.forge` exists before accessing - could cause runtime errors 😢 - Consider adding type checking for the `RULE` variable substitution to ensure it's a valid string
towry
added a commit
that referenced
this pull request
Nov 6, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 6, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 6, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 6, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 6, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 6, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 6, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 7, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore
towry
added a commit
that referenced
this pull request
Nov 8, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore wip: litellm
towry
added a commit
that referenced
this pull request
Nov 8, 2025
Revert "style(claude): format json array and remove output style setting (#147)" This reverts commit a1732f2910d44be7a3c9646c26864ccfa3b39f95. chore wip: litellm Co-authored-by: Towry Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.