Adding KtLint #116
Open
Adding KtLint #116
+357
−391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed backgroundDispatcher to BackgroundDispatcher
TadeasKriz
requested changes
Oct 28, 2025
| root = true | ||
|
|
||
| [*.{kt,kts}] | ||
| end_of_line = lf |
There was a problem hiding this comment.
Should we set this? Git automatically changes end_of_line based on the platform so this might result in a lot of changes if this project is opened on Windows.
There was a problem hiding this comment.
Oh interesting point. It's in the other .editorConfigs in other projects so we'd want to remove it from those as well.
build.gradle.kts
Outdated
| alias(libs.plugins.dokka) apply false | ||
| alias(libs.plugins.touchlab.docusaurusosstemplate) | ||
| alias(libs.plugins.mavenPublish) apply false | ||
| id("org.jlleitschuh.gradle.ktlint") version "12.2.0" apply false |
There was a problem hiding this comment.
Please move this to libs.versions.toml?
.github/workflows/build.yml
Outdated
| - name: Run Gradle Build | ||
| run: ./gradlew build --no-daemon --stacktrace --no-build-cache | ||
| run: ./gradlew ktlintCheck build --no-daemon --stacktrace --no-build-cache |
There was a problem hiding this comment.
build includes check, and since we configured check to depend on ktlintCheck, we don't need to specify it explicitly here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.