Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dsenalik
Copy link
Contributor

@dsenalik dsenalik commented Apr 12, 2024

Bug Fix

Closes #1848

Tripal Version: 4.x

Description

Apparently some ontologies have been updated, so automated tests are failing as we get different numbers of table row than previously. Affected so far: PR #1844, PR #1846, PR #1847

Testing?

A quick code review is always good, but automated testing should do the real testing.

@dsenalik dsenalik added bug - confirmed For issues where a core developer has confirmed a bug exists. Tripal 4 Group 9 - Automated Testing Any issue related to automated testing including needed test cases, concerns, etc. labels Apr 12, 2024
Copy link
Member

@laceysanderson laceysanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look perfect -thanks @dsenalik

@laceysanderson laceysanderson merged commit b57bdd7 into 4.x Apr 12, 2024
@laceysanderson laceysanderson deleted the tv4g9-issue1848-update_prepare_sql branch April 12, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug - confirmed For issues where a core developer has confirmed a bug exists. Group 9 - Automated Testing Any issue related to automated testing including needed test cases, concerns, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing is currently failing

2 participants