Fix bug in publish showing up in testing environment #1854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2024
laceysanderson
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
This is a nice clean fix and I love the addition to the test --Thank you @dsenalik for figuring this out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Closes #1853
Tripal Version: 4.x
Description
Tripal publish is missing braces
{ }in a couple of sql queries, and having a variable inside{$field_table}is not parsed as expected.Testing?
Because this is showing up in the testing environment, check that tests pass. (sorry I messed up the branch name)