-
Notifications
You must be signed in to change notification settings - Fork 51
New Widgets for Property Fields #1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have tested the setting on a Tripal docker site. The drop downs all showed as expected after config 🎉 |
tripal_chado/src/Plugin/Field/FieldWidget/ChadoPropertySelectWidgetDefault.php
Outdated
Show resolved
Hide resolved
tripal_chado/src/Plugin/Field/FieldWidget/ChadoPropertySelectWidgetDefault.php
Outdated
Show resolved
Hide resolved
tripal_chado/src/Plugin/Field/FieldWidget/ChadoPropertySelectWidgetDefault.php
Outdated
Show resolved
Hide resolved
tripal_chado/src/Plugin/Field/FieldWidget/ChadoPropertySelectWidgetDefault.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tripal_chado/src/Plugin/Field/FieldWidget/ChadoPropertySelectWidgetDefault.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Douglas Senalik <[email protected]>
Co-authored-by: Douglas Senalik <[email protected]>
Co-authored-by: Douglas Senalik <[email protected]>
Co-authored-by: Douglas Senalik <[email protected]>
Co-authored-by: Douglas Senalik <[email protected]>
|
Thanks for the review @ruobinLiu and the suggestions @dsenalik! I just confirmed that I can still reproduce this and that the simple fix was not quite enough 🙈 I will look into this. I agree that it should not show 2X, especially after the data is already gone.
|
tripal_chado/src/Plugin/Field/FieldWidget/ChadoPropertySelectWidgetDefault.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Douglas Senalik <[email protected]>
tripal_chado/src/Plugin/Field/FieldWidget/ChadoPropertySelectWidgetDefault.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Douglas Senalik <[email protected]>
|
Thanks for all the suggestions @dsenalik, I've confirmed that it now works locally. Can you revise your review? |
Tripal 4 Core Dev Task
No Linked Issue; Playing over weekend
Tripal Version: 4
Description
This PR adds two new widgets to the core property fields:
These were added to improve the experience of data entry for curators and to allow admin to control the entries accepted for various metadata.
Note: The select widget configuration UI specifically does not support a key => value mapping as we want to ensure the value entered for metadata matches what is displayed.
Testing?
- None -will be chosen and a warning will be shown to the curator.