Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ChadoAdditionalTypeTypeDefault can be manually added #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 23, 2024
Merged

ChadoAdditionalTypeTypeDefault can be manually added #1942

merged 7 commits into from
Aug 23, 2024

Conversation

@dsenalik
Copy link
Contributor

@dsenalik dsenalik commented Aug 1, 2024 •
edited
Loading

Bug Fix

Closes #1941

Tripal Version: 4.x

Description

We were unable to add the ChadoAdditionalTypeTypeDefault field manually. This is now fixed.

Also revert an inadvertent recent change from PR #1940 i.e. https://github.com/tripal/tripal/pull/1940/files#r1709455275

Testing

  1. Tripal -> Page Structure -> Contact -> Manage Fields
  2. Remove the "Contact Type" field (Chado Type Reference).
  3. Click "+Create a new field"
  4. Manually add this field type back, the CV term was "Communication Contact" but any will do.
  5. Now create a new contact entity and specify any CV term for the type. Contact will be created without error.

@dsenalik dsenalik added bug - confirmed For issues where a core developer has confirmed a bug exists. Tripal 4 Group 1 - Tripal Content Types | Terms | Fields Any issue relating to Tripal Content including types, terms, and fields. labels Aug 1, 2024
@dsenalik dsenalik mentioned this pull request Aug 1, 2024
Closed
@dsenalik dsenalik mentioned this pull request Aug 8, 2024
Merged
laceysanderson
laceysanderson approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@laceysanderson laceysanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code looks good, clean and simple
✅ Able to add a type field to the contact as described
✅ Able to create/edit a contact with the new field and the type is set as it should be.

Thanks for the fix @dsenalik! This is ready to merge! 🎉

@laceysanderson laceysanderson merged commit 7ef42b4 into 4.x Aug 23, 2024
@laceysanderson laceysanderson deleted the tv4g1-issue1941-additional-type-field branch August 23, 2024 19:36
@laceysanderson laceysanderson mentioned this pull request Oct 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laceysanderson laceysanderson laceysanderson approved these changes

Assignees

No one assigned

Labels

bug - confirmed For issues where a core developer has confirmed a bug exists. Group 1 - Tripal Content Types | Terms | Fields Any issue relating to Tripal Content including types, terms, and fields.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't add "Chado Type Reference" field

2 participants

@dsenalik @laceysanderson