Add in schema for options all supported tripal_layout field group options. #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsenalik
approved these changes
Oct 7, 2024
Contributor
dsenalik
left a comment
There was a problem hiding this comment.
Minor typos but once tests finish I approve
laceysanderson
commented
Oct 7, 2024
Co-authored-by: Douglas Senalik <[email protected]>
Member
Author
|
Thanks for the quick review @dsenalik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Issue #1862
Tripal Version:
Description
I missed this in the original PR referenced 🙈 We need schema definitions for all options supported in the YAML but the original PR only included the main ones we had previously used and that are represented in the test yamls. This PR adds all the supported ones.
Note: this came about because we are using the Tripal Layout in our TripalCultivate extension module and it's test yamls have a description. As such all our tests are failing with a missing schema note about the description.
Testing?
This is a schema only change. It is much more difficult to test manually then it is worth. As such, code review and confirm it doesn't break existing tests.