Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@laceysanderson
Copy link
Member

@laceysanderson laceysanderson commented Feb 26, 2025

Bug Fix

Issue #2138

Description

As reported in the linked issue, install of Tripal via composer on Drupal 11 is not working as expected. This PR is working to fix this and add a github workflow to ensure it doesn't happen again. It is also adding some documentation to the README to make version compatibility more clear.

Here is the new README. Changes made include

  • Change header to say Drupal 11 instead of 10
  • Change target version to Drupal 11
  • Make it clear we currently recommend using the dev version when making new sites
  • Add table indicating versions needed for previous alpha releases
  • Updated requirements for alpha3

UpdatedReadme

Testing?

This requires testing the install manually without using Tripaldocker or devcontainer.

Instead, you can use the Drupal docker image which does not have Tripal downloaded/installed and DO NOT mount tripal when creating the container.

The following will pull down a drupal image with D11.1.x, PHP8.3 and Pgsql11, create a container from it, use composer to pull down tripal (this branch) inside the container, install tripal inside the container.

docker run --publish=80:80 --name=drupaldocker -tid \
  tripalproject/tripaldocker-drupal:drupal11.1.x-dev-php8.3-pgsql17
docker exec --workdir=/var/www/drupal drupaldocker \
  composer require --dev "tripal/tripal:dev-tv4g0-2138-installIssues" \
  --no-interaction --with-all-dependencies
docker exec drupaldocker /var/www/drupal/vendor/drush/drush/drush \
  pm-install tripal tripal_biodb tripal_chado tripal_layout --yes

@laceysanderson laceysanderson added bug - confirmed For issues where a core developer has confirmed a bug exists. Group 0 - Maintenance | Docker | Misc Any issue that doesn't fit into the other groups (i.e. docker, github actions) Group 9 - Automated Testing Any issue related to automated testing including needed test cases, concerns, etc. Priority - High Any issue/PR which has a noticable impact on usability of the system + would often be encountered. labels Feb 26, 2025
@laceysanderson laceysanderson self-assigned this Feb 26, 2025
@laceysanderson laceysanderson linked an issue Feb 26, 2025 that may be closed by this pull request
@laceysanderson laceysanderson marked this pull request as ready for review February 26, 2025 18:30
@laceysanderson laceysanderson linked an issue Feb 27, 2025 that may be closed by this pull request
@laceysanderson laceysanderson added the Easy PR Review πŸ˜€ Small easy to review pull request label Feb 27, 2025
@laceysanderson
Copy link
Member Author

Comments on the linked issue show a community manual test was successful (see screenshot). That in combination with the fact that this has great test coverage and is a small change, feels like enough validation to me to forgo an official review.

@laceysanderson laceysanderson merged commit a8d662d into 4.x Feb 27, 2025
31 checks passed
@laceysanderson laceysanderson deleted the tv4g0-2138-installIssues branch February 27, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug - confirmed For issues where a core developer has confirmed a bug exists. Easy PR Review πŸ˜€ Small easy to review pull request Group 0 - Maintenance | Docker | Misc Any issue that doesn't fit into the other groups (i.e. docker, github actions) Group 9 - Automated Testing Any issue related to automated testing including needed test cases, concerns, etc. Priority - High Any issue/PR which has a noticable impact on usability of the system + would often be encountered.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable Tripal 4.0.0-alpha2 on Drual 11

1 participant