-
Notifications
You must be signed in to change notification settings - Fork 51
Ensure composer install works on all supported versions. #2139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comments on the linked issue show a community manual test was successful (see screenshot). That in combination with the fact that this has great test coverage and is a small change, feels like enough validation to me to forgo an official review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug - confirmed
For issues where a core developer has confirmed a bug exists.
Easy PR Review π
Small easy to review pull request
Group 0 - Maintenance | Docker | Misc
Any issue that doesn't fit into the other groups (i.e. docker, github actions)
Group 9 - Automated Testing
Any issue related to automated testing including needed test cases, concerns, etc.
Priority - High
Any issue/PR which has a noticable impact on usability of the system + would often be encountered.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Issue #2138
Description
As reported in the linked issue, install of Tripal via composer on Drupal 11 is not working as expected. This PR is working to fix this and add a github workflow to ensure it doesn't happen again. It is also adding some documentation to the README to make version compatibility more clear.
Here is the new README. Changes made include
Testing?
This requires testing the install manually without using Tripaldocker or devcontainer.
Instead, you can use the Drupal docker image which does not have Tripal downloaded/installed and DO NOT mount tripal when creating the container.
The following will pull down a drupal image with D11.1.x, PHP8.3 and Pgsql11, create a container from it, use composer to pull down tripal (this branch) inside the container, install tripal inside the container.