tests: Use insta instead of expect-test for public API test
#568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blessing and diffing has a better UI with `insta`, so let's use that instead.
|
Just went through using this change in #576 and it was a much friendlier experience than I remember (although I'm already plenty familiar with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure in https://github.com/trishume/syntect/actions/runs/12734263547/job/35491626740?pr=565 (for #565) was too verbose and not very friendly.
Let's switch to
instawhich has a better way to deal with snapshots.Marking as Draft until I have had time to do some more experiments. And to give others a chance to give feedback on the change as such.