Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@amotin
Copy link
Collaborator

@amotin amotin commented Dec 9, 2024

No description provided.

oshogbo and others added 3 commits December 9, 2024 14:35
Prevent kernel panic by not running ISPCTL_FCLINK_TEST after a
failed ISPCTL_ABORT_CMD.

Reviewed by:	mav
Tested by:	Arne Steinkamm <[email protected]>
MFC after:	3 days
Differential Revision:	https://reviews.freebsd.org/D45718

(cherry picked from commit 8aa9192ce98aec07b24f8279c709237dd2c4421b)
When aborting command waiting in restart queue remove it from the
queue before freeing it.  This should fix NULL dereference panics
we saw on some very busy system.

MFC after:	2 weeks

(cherry picked from commit 40fb1b8bc1cf452d83edc5b25bc1d8bd13c0e72d)
 - When handling notify acknowledge from target code for task abort
request, not only send abort to the firmware, but also delete the
ATIO private data associated with the command.  It is required for
proper tag reuse, allowing new "conflicting" commands to be passed
to the target.  CTL was already fixed to handle that right, instead
of delaying them in restart queue of the driver.
 - When target finally aborts the command (which it should have
done before the notify ack) we should not send another abort to
the firmware.  Since we already sent the abort and deleted ATIO
private data above, just return successful completion here, doing
nothing.  Since the tag can be reused by that time, we can not
rely on its uniqueness, so when searching to the ATIO private data
compare also the aborted CCB pointer in addition to the tag.
 - Fix BA_RJT sending in isp_acknak_abts().  While it should be
rare, teach the code to send error responses for ABTS requests.

MFC after:	2 weeks

(cherry picked from commit ec3175fc3b2c1b07144a85e6a3e2fe534acc0c87)
@bugclerk bugclerk changed the title Fix FC task aborts handling issues NAS-132969 / None / Fix FC task aborts handling issues Dec 9, 2024
@bugclerk
Copy link

bugclerk commented Dec 9, 2024

@amotin amotin requested review from ixhamza and umsaleem December 9, 2024 19:52
@amotin amotin merged commit de45613 into truenas/13-stable Dec 10, 2024
@amotin amotin deleted the NAS-132969-13.0 branch December 10, 2024 15:20
@bugclerk
Copy link

Not updating JIRA ticket https://ixsystems.atlassian.net/browse/NAS-132969 target versions as no JIRA version corresponds to this PR

@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants