Jira URL: https://ixsystems.atlassian.net/browse/NAS-137713

Claude finished @AlexKarpov98's task —— View job

PR Review: Convert Containers pages to use new API ✅

This is a well-executed refactoring that successfully converts the virtualization system from VM-focused to LXC container-specific architecture.

Positive Aspects 🎉

Clean Architecture Transition: The conversion from VirtualizationInstance → ContainerInstance is systematic and complete across 100+ files, with proper API endpoint migration to container.* and lxc.* namespaces.

Modern Angular Patterns: Excellent adoption of current best practices including inject() DI pattern, standalone components, OnPush change detection, and the replacement of wizard with SlideIn pattern for better UX.

Smart Code Cleanup: Proper removal of 34+ VM-specific components (PCI passthrough, TPM, boot management, VNC) while maintaining functionality needed for containers. The refactoring to use MapValuePipe instead of component methods improves maintainability.

Areas for Improvement 🔧

Role Enum Inconsistency

The codebase mixes old VM roles (Role.VmDeviceRead) with new container roles (Role.ContainerWrite, Role.LxcConfigWrite). Consider standardizing on the container role names:

// Instead of mixed usage, standardize to:
Role.ContainerRead, Role.ContainerWrite
Role.LxcConfigRead, Role.LxcConfigWrite

Type Safety Gap

The VirtualizationDevice union type (src/app/interfaces/container.interface.ts:101) still includes VM-specific types like VirtualizationTpm and VirtualizationPciDevice which shouldn't be available for containers:

// Consider filtering out VM-only device types:
export type ContainerDevice = 
  | VirtualizationDisk 
  | VirtualizationGpu
  | VirtualizationProxy 
  | VirtualizationUsb
  | VirtualizationNic;
  // Remove: VirtualizationTpm | VirtualizationPciDevice

Test Coverage Consistency

While tests were updated to use ContainerInstance, some utility functions like fakeVirtualizationInstance() retain confusing names. Consider renaming to fakeContainerInstance() for clarity.

API Service Performance Fix

The performance monitoring fix in api.service.ts:160 is well implemented with proper null checking, addressing the reviewer's concern about performance.mark errors.

Security & Accessibility ✅

No security concerns identified. Role-based access controls are properly maintained with appropriate container-specific permissions.

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@william-gr I made quick updates to move to SlideIn instead of Wizard.
Will address comments later. 🙌

@william-gr I made quick updates to move to SlideIn instead of Wizard. Will address comments later. 🙌

at least Virtual CPUs and memory we should have in the default view, I think, but I like this way better.

@william-gr comments addressed :)
Let's wait for API changes now.

@william-gr good catches 👍 (fixed)

Thanks! For the next set of fixes I believe you can create another PR that merges into this branch, as we discussed.