fix: Prometheus HTTP server not started #1517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Prometheus HTTP server was not started due to a bug. This commit required some refactoring of the code in order to properly start/stop the metrics server. closes trustbloc#1516 Signed-off-by: Bob Stasyszyn <[email protected]>
fqutishat
approved these changes
Nov 10, 2022
sandrask
approved these changes
Nov 10, 2022
Codecov ReportBase: 88.04% // Head: 88.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
==========================================
+ Coverage 88.04% 88.15% +0.10%
==========================================
Files 218 219 +1
Lines 20845 20847 +2
==========================================
+ Hits 18354 18377 +23
+ Misses 1598 1576 -22
- Partials 893 894 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Prometheus HTTP server was not started due to a bug. This commit required some refactoring of the code in order to properly start/stop the metrics server.
closes #1516
Signed-off-by: Bob Stasyszyn [email protected]