Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

werdnanoslen
Copy link
Contributor

Summary

Adds a component and storybook examples of an asterisk-based required field marker in labels

Related Issues or PRs

Resolves #2523

How To Test

In storybook, see the component itself in Form elements / Label / With Required Marker
and an example on the address template

Screenshots (optional)

image image

@werdnanoslen
Copy link
Contributor Author

Before merging, need to update the Form stories to use this component

@werdnanoslen
Copy link
Contributor Author

@brandonlenz in #2523 (comment):

This might need to be able to be applied to a fieldset legends as well

@werdnanoslen
Copy link
Contributor Author

@brandonlenz added to fieldset 👍

@werdnanoslen werdnanoslen requested review from a team as code owners September 29, 2023 19:44
Copy link
Contributor

@shkeating shkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@werdnanoslen werdnanoslen enabled auto-merge (squash) October 19, 2023 22:19
@werdnanoslen werdnanoslen merged commit c5f2b40 into main Oct 19, 2023
@werdnanoslen werdnanoslen deleted the an-asterisk-2523 branch October 19, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] Create required asterisk component

2 participants