Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support display and ephemeral in Docker provider #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddupont808 merged 3 commits into from
Oct 24, 2025
Merged

Support display and ephemeral in Docker provider #514

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cb2c6c
Forward display resolution to Docker based sandboxes
ddupont808 Oct 24, 2025
b1eae0f
use dict for display
ddupont808 Oct 24, 2025
efb52bd
Delete ephemeral containers when stopped
ddupont808 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 32 additions & 7 deletions libs/python/computer/computer/providers/docker/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,14 +258,20 @@ async def run_vm(
logger.info(f"Container {name} is already running")
return existing_vm
elif existing_vm["status"] in ["stopped", "paused"]:
# Start existing container
logger.info(f"Starting existing container {name}")
start_cmd = ["docker", "start", name]
result = subprocess.run(start_cmd, capture_output=True, text=True, check=True)
if self.ephemeral:
# Delete existing container
logger.info(f"Deleting existing container {name}")
delete_cmd = ["docker", "rm", name]
result = subprocess.run(delete_cmd, capture_output=True, text=True, check=True)
else:
# Start existing container
logger.info(f"Starting existing container {name}")
start_cmd = ["docker", "start", name]
result = subprocess.run(start_cmd, capture_output=True, text=True, check=True)

# Wait for container to be ready
await self._wait_for_container_ready(name)
return await self.get_vm(name, storage)
# Wait for container to be ready
await self._wait_for_container_ready(name)
return await self.get_vm(name, storage)

# Use provided image or default
docker_image = image if image != "default" else self.image
Expand Down Expand Up @@ -307,6 +313,20 @@ async def run_vm(
cmd.extend(["-e", "VNC_PW=password"]) # Set VNC password
cmd.extend(["-e", "VNCOPTIONS=-disableBasicAuth"]) # Disable VNC basic auth

# Apply display resolution if provided (e.g., "1024x768")
display_resolution = run_opts.get("display")
if (
isinstance(display_resolution, dict)
and "width" in display_resolution
and "height" in display_resolution
):
cmd.extend(
[
"-e",
f"VNC_RESOLUTION={display_resolution['width']}x{display_resolution['height']}",
]
)

# Add the image
cmd.append(docker_image)

Expand Down Expand Up @@ -388,6 +408,11 @@ async def stop_vm(self, name: str, storage: Optional[str] = None) -> Dict[str, A

logger.info(f"Container {name} stopped successfully")

# Delete container if ephemeral=True
if self.ephemeral:
cmd = ["docker", "rm", name]
result = subprocess.run(cmd, capture_output=True, text=True, check=True)

return {
"name": name,
"status": "stopped",
Expand Down