Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix broken test: VMDetailsPrinterTests #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Fix broken test: VMDetailsPrinterTests #38

merged 1 commit into from
Mar 10, 2025

Conversation

@aktech
Copy link
Contributor

@aktech aktech commented Mar 10, 2025

The test in tests/VM/VMDetailsPrinterTests.swift was broken.

Building for debugging...
[4/4] Write swift-version--58304C5D6DBC2206.txt
Build complete! (0.17s)
Building for debugging...
/Users/aktech/dev/lume/tests/VM/VMDetailsPrinterTests.swift:13:87: error: missing argument for parameter 'display' in call
11 |                                              cpuCount: 2,
12 |                                              memorySize: 1024,
13 |                                              diskSize: .init(allocated: 24, total: 30),
   |                                                                                       `- error: missing argument for parameter 'display' in call
14 |                                              status: "status",
15 |                                              vncUrl: "vncUrl",

/Users/aktech/dev/lume/src/VM/VMDetails.swift:43:5: note: 'init(name:os:cpuCount:memorySize:diskSize:display:status:vncUrl:ipAddress:)' declared here
41 |     let ipAddress: String?
42 |
43 |     init(
   |     `- note: 'init(name:os:cpuCount:memorySize:diskSize:display:status:vncUrl:ipAddress:)' declared here
44 |         name: String,
45 |         os: String,

/Users/aktech/dev/lume/tests/VM/VMDetailsPrinterTests.swift:51:87: error: missing argument for parameter 'display' in call
49 |                                              cpuCount: 2,
50 |                                              memorySize: 1024,
51 |                                              diskSize: .init(allocated: 24, total: 30),
   |                                                                                       `- error: missing argument for parameter 'display' in call
52 |                                              status: "status",
53 |                                              vncUrl: "vncUrl",

/Users/aktech/dev/lume/src/VM/VMDetails.swift:43:5: note: 'init(name:os:cpuCount:memorySize:diskSize:display:status:vncUrl:ipAddress:)' declared here
41 |     let ipAddress: String?
42 |
43 |     init(
   |     `- note: 'init(name:os:cpuCount:memorySize:diskSize:display:status:vncUrl:ipAddress:)' declared here
44 |         name: String,
45 |         os: String,
[7/8] Compiling lumeTests VMDetailsPrinterTests.swift
error: fatalError

This was due to missing display argument. This PR fixes the same.

@f-trycua
Copy link
Collaborator

Approved. Thanks for your contribution @aktech!

@f-trycua f-trycua merged commit d153e1a into trycua:main Mar 10, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f-trycua f-trycua f-trycua approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aktech @f-trycua