Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Document mock options as an optional parameter #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2022
Merged

Document mock options as an optional parameter #350

merged 1 commit into from
Feb 21, 2022

Conversation

@aaclayton
Copy link

@aaclayton aaclayton commented Feb 20, 2022 •
edited
Loading

The mock method currently documents its options parameter as being required. This causes annoying code inspection errors in the IDE when passing only a single object as folows:

mock({
  "some-directory": {
    "some-file.txt": "file content"
  }
});

image

This change makes the parameter optional as intended.

@3cp 3cp merged commit f696b2c into tschaub:main Feb 21, 2022
@3cp
Copy link
Collaborator

3cp commented Feb 21, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaclayton @3cp