fix timeout in failing test #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on https://github.com/tschaub/mock-fs/blob/main/changelog.md#400 I noticed that tests would timeout when some assertions failed because done was never called. ``` promise.then(() => { assert(false) done() }, done) ``` The issue is that `then` will only call one of it's two callbacks. The onRejected function is not called when onFulfilled throws an error. Switching to `.catch(done)` guarnatees the a rejected promise chain marks the test as completed.
tschaub
approved these changes
Sep 26, 2024
|
Thank you, @everett1992. This was a long-standing oversight! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on
https://github.com/tschaub/mock-fs/blob/main/changelog.md#400 I noticed
that tests would timeout when some assertions failed because done was
never called.
The issue is that
thenwill only call one of it's two callbacks. TheonRejected function is not called when onFulfilled throws an error.
Switching to
.catch(done)guarnatees the a rejected promise chainmarks the test as completed.