This repository was archived by the owner on Aug 15, 2025. It is now read-only.
refactored gerber and excellon drill into circuit-json-to-gerber #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveibar
reviewed
Sep 12, 2024
| export * from "./lib/types" | ||
| export * from "./lib/utils" | ||
| export * from "./lib/gerber" | ||
| export * from "./lib/excellon-drill" |
There was a problem hiding this comment.
can we add export * from "circuit-json-to-gerber" for backwards compatibility? It'll break less things
seveibar
approved these changes
Sep 12, 2024
|
@seveibar why is this format bot failing? |
|
hmm i think it's using an old broken version of formatbot, can you update the formatbot workflow with the latest one from tscircuit/plop |
|
@seveibar the new one is expecting biome should I format files with biome? |
|
OOPS i forgot this repo used prettier- no we shouldn't do a full format right now- lets just remove that workflow for now. We can format this repo in a future pr |
This was referenced Sep 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.