-
Notifications
You must be signed in to change notification settings - Fork 96
Bugfixes and enhancements #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, this clears up their usage in both Record Page and Screen Flows
This allows parent LWCs to slot in custom actions if you want to implement another abstraction on top of any of the datatables
…ookup inline editing
But sadly, this doesn't open lightning-combobox and click() doesn't work either...
The official installation link for es6 module minified is broken so I manually ran the full through https://javascript-minifier.com/
So I can ctrl+f better
This is meant to be debounced, as a workaround for when lightning-datatable is fully "rendered" when there are editable cells (of custom data types) for display
|
For transparency, I've rewritten history recently with a squash of the recent two PRs. This cleans up some of the commit history as I was not anticipating to MVP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be the final PR before spring 21, designed to add a bit more polish and bugfixes.
I'll be keeping it open for additional commits until the weekend after release.
Additionally, this should be rebased on top of
masterafter #65