ci: golangci-linter add unused #3119
Conversation
4fd56d3 to
7684f41
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3119 +/- ##
==========================================
- Coverage 60.55% 58.30% -2.25%
==========================================
Files 598 598
Lines 39904 49917 +10013
==========================================
+ Hits 24162 29104 +4942
- Misses 15742 20813 +5071
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7684f41 to
cc0b337
Compare
rminnich
left a comment
There was a problem hiding this comment.
overall, this is pretty great. Please see my comments, you are welcome to ignore or respond to them.
f8907c2 to
5402bb6
Compare
|
See my comment in unresolved conversation about usage. |
rminnich
left a comment
There was a problem hiding this comment.
Some of this looks really good. If you can break this up, and remove all the files from it that. have nolint: tags, such that we can fix them, I would be more comfortable.
Another example: testBaseLimtType should be fixed, not have a nolint: tag.
|
|
||
| // TODO: get author review | ||
| // | ||
| //nolint:unused |
There was a problem hiding this comment.
just remove the parameter, right?
There was a problem hiding this comment.
The problem is that the function is not called, and I wanted the authors to review that to check why this is the case. @RiSKeD authored this so he might want to comment on that before we remove it.
There was a problem hiding this comment.
Yes, this is fine for now. I will do a PR with a fix using it. Thanks for the headsup
There was a problem hiding this comment.
The function is now being used, so you can remove the linter tag
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
unusedlinter to thegolangci-lintrunnerThis PR covers most of the codebase (see the new exclude directories). There are some commands where I would like to get the authors' review (if possible) to minimize the code size further.