-
Notifications
You must be signed in to change notification settings - Fork 32
Architecture update #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Architecture update #120
Conversation
Allows for thinner wrapping of ROS Actions while still supporting logical translation style from LogicalNavigation Remove "n-1" from Clingo interface due to new modeling Co-authored-by: Yuqian Jiang <[email protected]>
Allows for thinner wrapping of ROS Actions while still supporting logical translation style from LogicalNavigation Remove "n-1" from Clingo interface due to new modeling Co-authored-by: Yuqian Jiang <[email protected]>
Wrong parameter passing would cause actions to not be registered with their logical name Remove dependency on bwi_logical_translator Co-authored-by: Yuqian Jiang <[email protected]>
Changes to plan_execution have altered the action executor interface, so we'll eventually have to do some updates here
Support empty rule bodies in goal query (i.e., a query that passes a fact) Don't timestamp facts in the head of a goal query Co-authored-by: Yuqian Jiang <[email protected]>
Avoid transforming entire pointclouds Move perception code to libbwi_perception Make directories for library code
Spread code out amongst a few more headers for clarity Initial refactoring of horizontal plane extraction
Fix bug with isGoalReached in BlindActionExecutor
Some moving of functions
Change NULL to nullptr Change throw() to noexcept Use sharedptrs for actions, as they have the most delicate lifecycle
Flip filter sign. We want the slice, not the rest of the cloud Set frame name correctly
Tweak interfaces to support additional arguments
This is used by plan executor to re-sense the robot's location upon receiving a new goal.
Co-authored-by: Yuqian Jiang <[email protected]>
Move all knowledge of parameters and name into subclasses Handle failed state
Update to match Clingo 4.5.1 behavior concerning incmode
Print more information when failing to instantiate executors Co-authored-by: Nick Walker <[email protected]>
Extend ExecutionObserver with plan termination event Add python fluent msg helpers Co-authored-by: Yuqian Jiang <[email protected]>
Support a standardized wrapping for Smach state machines wrapped as action servers Tighten up RosAction interface Avoid run loop architecture for RosActions, and prefer goal construction and finished callbacks
for the purpose of storing groceries
Ported from RoboCup Move plan execution ros wrapper up into plan execution to facilitate code reuse between BWI and villa Move observers up to plan execution to facilitate reuse Refactor bwi_kr plan execution node to use the new shared wrapper Drop some bwi_kr_execution nodes that will be obsolete once knowledge_representation integration is done Commented out some actions that depend on logical translation updates Update bwi_kr_execution to use new LogicalNavigation superclass Update LogicalAction type Co-authored-by: Yuqian Jiang <[email protected]>
Visit door list works again
Fix populate_with_map and goal formulator
|
Actions for taking the elevator are removed from the new planning domain, so the old elevator demo will not work after the merge. |
YuqianJiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There are plans in AMRL to further develop and generalize the SMADS |
|
Going to try to get Travis back online in this repo, after that I think this is good to go. |
* Create main.yml * Update main.yml adds rosdep pull * Update main.yml * updates * updates * updates * updates * updates * missing definition * missing definition
|
Travis has been replaced with GH actions as of #122. Once that check passes on this branch, it's ready to be merged into master. |
This merges in the architecture-updates that have been written for RoboCup@Home and been living independently on this branch.
The updates are numerous.