Fix call of usage when packing dependencies for one architecture only #5432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc stated to run `./scripts/pack_dependencies.sh . macos arm64 x86_64` to pack dependencies for universal binaries. However, if you just want to build it for running it locally with the command `./scripts/pack_dependencies.sh . macOS arm64`, the `usage()` method will get called. This fix let you pack dependencies for one architecture only.
|
Sorry, what's the purpose of running this with one architecture? |
cde503b to
c3e08c3
Compare
3fdf38c to
5c29a52
Compare
3c98442 to
a0978bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc stated to run
./scripts/pack_dependencies.sh . macos arm64 x86_64to pack dependencies for universal binaries.However, if you just want to build it for running it locally with the command
./scripts/pack_dependencies.sh . macOS arm64, theusage()method will get called.This fix let you pack dependencies for one architecture only.