dd: handle SIGUSR1 directly. not just every 1sec #6025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6eca368 to
cf5fc49
Compare
cf5fc49 to
c2613ad
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Mar 23, 2024
|
|
||
| pub fn is_triggered(&self) -> bool { | ||
| self.trigger.swap(false, Relaxed) | ||
| pub fn manual_trigger_fn(&self) -> Box<dyn Send + Sync + Fn()> { |
There was a problem hiding this comment.
it would be nice to add some comments explaining what it is doing
sylvestre
reviewed
Mar 23, 2024
| } | ||
| } | ||
|
|
||
| fn flush_caches_full_length(i: &Input, o: &Output) -> std::io::Result<()> { |
c2613ad to
a35dafc
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
naoNao89
added a commit
to naoNao89/coreutils
that referenced
this pull request
Oct 17, 2025
Add proper retry loops for ErrorKind::Interrupted in I/O operations to handle signals like SIGUSR1 that can interrupt read/write calls. This pattern is proven in production - identical to PR uutils#6025 (merged March 2024) which fixed dd's EINTR handling for GNU test dd/stats.sh. The same pattern is already used in 9+ utilities (head, tail, tee, wc, sort, sum, tr, shuf, dd) without issues. Changes: - cat: Fix write_fast() and write_lines() to retry on EINTR - od: Fix PartialReader::read() in all three read paths - comm: Fix are_files_identical() for both file readers - tests: Add InterruptingReader/Writer test utilities Historical context: - Pattern validated by cre4ture's PR uutils#6025 (dd EINTR fix) - Matches existing implementations in dd/dd.rs:450,881 - POSIX best practice for signal-interrupted I/O Fixes uutils#1275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses issue #5902.
The relevant gnu test
tests/dd/stats.shis now green.Changes:
fullblockcmd line arg. It retries partial writes when this is set.