Fix clippy warning match_bool #6184
Merged
cakebaker merged 2 commits intouutils:mainfrom Apr 3, 2024
sylvestre:match_bool
Merged
Fix clippy warning match_bool #6184cakebaker merged 2 commits intouutils:mainfrom sylvestre:match_bool
cakebaker merged 2 commits intouutils:mainfrom
sylvestre:match_bool
Conversation
|
GNU testsuite comparison: |
Contributor
|
Did you see that there are still some clippy errors? |
|
GNU testsuite comparison: |
Comment on lines
+1069
to
+1074
| if explicit { | ||
| (false, true) | ||
| } else { | ||
| (false, false) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Is there a reason why these lines can't just be (false, explicit)? Also, when touching the code, can you document what the bools mean?
(I'm too late to the party; I hope you still have motivation to improve this?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.