Merged
Conversation
Thankfully, this revealed no bugs. Let's prevent regressions!
8a3bf3c to
de37baa
Compare
Collaborator
Author
|
Changes since last push:
|
|
GNU testsuite comparison: |
|
|
||
| let scenario = TestScenario::new("invalid_name"); | ||
| symlink_file(scenario.bin_path, scenario.fixtures.plus("invalid_name")).unwrap(); | ||
| let child = Command::new(scenario.fixtures.plus("invalid_name")) |
Collaborator
There was a problem hiding this comment.
Would it make sense to adapt the test framework to support this so that we can write this test witht it?
Collaborator
Author
There was a problem hiding this comment.
Hmm, sure, it is possible to do so, but I don't see the benefit?
The tests "unrecognized name" and "non-UTF-8 name" are likely going to be the only use cases for this. Perhaps one more edge case that I overlooked, but I really don't see the advantage to make this more generally available.
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
src/bin/coreutils.rshad abysmal coverage. Turns out, we don't have any tests for most features of our "multi-call binary" logic!This PR fixes that by adding a few tests, namely:
Thankfully, this revealed no bugs. Let's prevent regressions!
EDIT: From 19% to 68%: https://app.codecov.io/gh/uutils/coreutils/blob/BenWiederhake%2Fcoreutils-rs%3Adev-better-test-coverage/src%2Fbin%2Fcoreutils.rs