kill: adding support for handling SIGEXIT#6269
Merged
BenWiederhake merged 4 commits intouutils:mainfrom Apr 27, 2024
Merged
Conversation
sylvestre
reviewed
Apr 24, 2024
| .try_into() | ||
| .map_err(|e| std::io::Error::from_raw_os_error(e as i32))?; | ||
| let sig_name = signal_name_by_value(sig); | ||
| let sig: Option<Signal> = if sig_name.is_some_and(|name| name == "EXIT") { |
Contributor
There was a problem hiding this comment.
could you please add a comment, it isn't super obvious :)
Contributor
Author
There was a problem hiding this comment.
Yes, very good point! Added.
|
GNU testsuite comparison: |
tests/kill: test handling SIGEXIT kill: pass unqualified None for consistency
Contributor
Author
|
Rebased on main to attempt to fix CI and amend commit to follow best practices. |
BenWiederhake
approved these changes
Apr 27, 2024
Collaborator
BenWiederhake
left a comment
There was a problem hiding this comment.
Does exactly what it says on the tin, tests that the invocation works and will never regress. Great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for handling
SIGEXITas mentioned in Issue-6628.Before this change the nix library would return an
EINVALwhen passingSIGEXIT/EXITto uutils/coretutils kill.After this change nix passes
0to libc kill as shown here.