Thanks to visit codestin.com
Credit goes to github.com

Skip to content

more: use dev tty instead of mio to avoid panics#6262

Merged
cakebaker merged 2 commits intouutils:mainfrom
apatrushev:main
Apr 23, 2024
Merged

more: use dev tty instead of mio to avoid panics#6262
cakebaker merged 2 commits intouutils:mainfrom
apatrushev:main

Conversation

@apatrushev
Copy link
Contributor

Fixes #2362

@AMythicDev
Copy link
Contributor

AMythicDev commented Apr 23, 2024

Can you test this out with the filedescriptor feature rather than the use-dev-tty and see if it works the same? The filedescriptor is better documented in crossterm overall.

@apatrushev
Copy link
Contributor Author

Can you test this out with the filedescriptor feature rather than the use-dev-tty and see if it works the same? The filedescriptor is better documented in crossterm overall.

I tried filedescriptor feature and it did not fix the problem. According to the crossterm code filedescriptor feature enabled via use-dev-tty and use-dev-tty itself used as feature flag to opt-out mio as event source on unix.

@AMythicDev
Copy link
Contributor

Alright! I will add docs and file a PR for the use-dev-tty since it isn't documented in the README or lib.rs.

@cakebaker cakebaker merged commit 4234944 into uutils:main Apr 23, 2024
@cakebaker
Copy link
Contributor

Thanks for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

more crashes when attempting more lines than terminal lines

3 participants

Comments