sort: disable clippy::suspicious_open_options on OpenBSD#6292
Merged
cakebaker merged 1 commit intouutils:mainfrom Apr 30, 2024
Merged
sort: disable clippy::suspicious_open_options on OpenBSD#6292cakebaker merged 1 commit intouutils:mainfrom
cakebaker merged 1 commit intouutils:mainfrom
Conversation
- Avoid error on OpenBSD stable/7.5 with clippy (lint) - suspicious_open_options added in Rust 1.77.0 (1.76 used on OpenBSD 7.5) https://rust-lang.github.io/rust-clippy/master/index.html#/suspicious_open_options Fix uutils#6290 Signed-off-by: Laurent Cheylus <[email protected]>
Contributor
|
Thanks! |
Collaborator
|
@cakebaker did you see my comment here: #6290 (comment)? Happy to accept this if you want to have it merged, but I'd like to discuss it at least 😄 Edit: Actually, given that this is for CI and we want to make this a tier 1 platform. I agree with this change after all. Some discussion would have been nice though. |
Contributor
|
@tertsdiepraam sorry about that :| Yes, I saw your comment (and their answer), and thought that no further discussion was necessary... |
Collaborator
|
Alright, at least we agree on the outcome 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6290
Lint with
clippyand build OK on OpenBSD stable/7.5 and FreeBSD 14.0 (Rust version 1.77).