Merged
Conversation
|
GNU testsuite comparison: |
BenWiederhake
requested changes
May 7, 2024
Collaborator
BenWiederhake
left a comment
There was a problem hiding this comment.
LGTM, except that one typo. (I understand that the typo is also present in the already-existing code; feel free to keep it or fix it as you see fit.)
(Remaining CI failures are known issues #6275 and #6333, so out of scope for this PR.)
Before I merge this, I want to give the other maintainers an opportunity to look at it, because I don't feel 100% confident around symlinks. But this seems very reasonable.
Co-authored-by: Ben Wiederhake <[email protected]>
|
GNU testsuite comparison: |
BenWiederhake
approved these changes
May 8, 2024
Collaborator
BenWiederhake
left a comment
There was a problem hiding this comment.
LGTM. I'll wait for a few days for the others too look at it, because I don't feel 100% confident around the symlink code.
Contributor
Author
|
is it because I tried to squeeze in deref logic into parsing code |
Contributor
|
well done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr tries to fix gnu test case "link deref" for cp utility
these are the changes made:
when trying to copy a folder without
-Rbefore throwing "-r not specified" error, cp would make sure that source is not a symlink and noderef option is not given. This way, when both of them are given, it would treat it as a file and copy the symlink itself.to match gnu cp's behavior,
-Rwon't disable dereference if--linkis given