Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

util: added umask manipulation#6404

Merged
sylvestre merged 7 commits intouutils:mainfrom
matrixhead:umask-fix
May 19, 2024
Merged

util: added umask manipulation#6404
sylvestre merged 7 commits intouutils:mainfrom
matrixhead:umask-fix

Conversation

@matrixhead
Copy link
Contributor

This pr tries to add umask manipulation to test util, this would allow changing umask in a contained manner instead of doing it globally.

@matrixhead matrixhead marked this pull request as draft May 16, 2024 10:43
@matrixhead
Copy link
Contributor Author

matrixhead commented May 16, 2024

@tertsdiepraam is this okay? Should I port existing tests to utilize this?

@tertsdiepraam
Copy link
Collaborator

I love it!

@tertsdiepraam
Copy link
Collaborator

And yes, it'd be great if you could port a few tests (in a separate commit) so that we can see that this actually solves our issue.

Co-authored-by: Terts Diepraam <[email protected]>
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@matrixhead matrixhead marked this pull request as ready for review May 18, 2024 18:29
@sylvestre sylvestre merged commit 3c096ee into uutils:main May 19, 2024
@sylvestre
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants