-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
uudoc: fix manpage for individual utilities has wrong name (nit) #9152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When running `uudoc manpage <utility>` for any utility that isn't coreutils, the resulting manpage lists the command name as `uudoc`. This is because uu_app() functions sets Command::name to uucore::util_name(), which unless we've set utility_is_second_arg first, would be the executable name rather than the utility name.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
A failed test should pass just by updating (pulling main). |
|
GNU testsuite comparison: |
|
@oech3 yes, I was just too lazy to merge main back as it seems this is far back in the review queue (understandable! this is really not too important fix) |
|
GNU testsuite comparison: |
|
@sylvestre Would you fix this manpage issue before releasing 0.5.0? |
|
Thankyou |
uudoc: fix manpage for individual utilities has wrong name (nit)
uudoc: fix manpage for individual utilities has wrong name (nit)
(I'd create an issue, but I think this is really too much of a nit).
When running
uudoc manpage <utility>for any utility that isn't coreutils, the resulting manpage lists the command name asuudoc.This is because uu_app() functions sets Command::name to uucore::util_name(), which unless we've set utility_is_second_arg first, would be the executable name rather than the utility name.
(Head of) output of
uudoc manpage lsbefore this change:And after: