Thanks to visit codestin.com
Credit goes to github.com

Skip to content

stdbuf: use exec instead of forking #9495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ecordonnier wants to merge 1 commit into
base: main
Choose a base branch
from
Open

stdbuf: use exec instead of forking #9495

Ecordonnier wants to merge 1 commit into from

Conversation

@Ecordonnier
Copy link
Collaborator

@Ecordonnier Ecordonnier commented Nov 26, 2025 •
edited
Loading

forking creates a new PID and it not compatible with GNU coreutils implementation.

  • use Command::exec() instead of Command::spawn() which forks
  • add stdbuf test verifying that no forking happens

Fixes #9066

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@Ecordonnier

This comment was marked as resolved.

Sign in to view
@oech3

This comment was marked as resolved.

Sign in to view
@Ecordonnier Ecordonnier force-pushed the eco/stdbuf-exec-instead-of-fork branch from de2b66c to 0110357 Compare December 1, 2025 12:50
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9495 will not alter performance

Comparing Ecordonnier:eco/stdbuf-exec-instead-of-fork (7963769) with main (2000af8)

Summary

✅ 127 untouched
⏩ 6 skipped1

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@Ecordonnier Ecordonnier force-pushed the eco/stdbuf-exec-instead-of-fork branch from 0d7529b to 4c557bf Compare December 3, 2025 13:21
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@Ecordonnier
Copy link
Collaborator Author

Ecordonnier commented Dec 3, 2025

This is ready for review. I don't intend to work on this branch any more.

@Ecordonnier
Copy link
Collaborator Author

Ecordonnier commented Dec 9, 2025 •
edited
Loading

I've just seen #9013 (comment) which is also relevant for my PR. I'll check if Command::exec() can be used instead of Command::status().

@Ecordonnier Ecordonnier force-pushed the eco/stdbuf-exec-instead-of-fork branch from 4c557bf to 9afe842 Compare December 9, 2025 10:27
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@Ecordonnier Ecordonnier force-pushed the eco/stdbuf-exec-instead-of-fork branch from 9afe842 to af3957e Compare December 9, 2025 11:13
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@Ecordonnier
Copy link
Collaborator Author

Ecordonnier commented Dec 9, 2025

The PR is ready for review.

@Ecordonnier Ecordonnier force-pushed the eco/stdbuf-exec-instead-of-fork branch from af3957e to 197203c Compare December 9, 2025 20:54
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@Ecordonnier Ecordonnier force-pushed the eco/stdbuf-exec-instead-of-fork branch from 197203c to 8ae82a8 Compare December 9, 2025 21:23
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@Ecordonnier Ecordonnier force-pushed the eco/stdbuf-exec-instead-of-fork branch from 8ae82a8 to 11a9c80 Compare December 10, 2025 09:46
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@Ecordonnier
stdbuf: use exec instead of forking
7963769 
Forking creates a new PID and it not compatible with GNU coreutils implementation.
- use exec instead of forking
- add test verifying that execvp is used

Fixes uutils#9066

Signed-off-by: Etienne Cordonnier <[email protected]>
@Ecordonnier Ecordonnier force-pushed the eco/stdbuf-exec-instead-of-fork branch from 11a9c80 to 7963769 Compare December 17, 2025 09:35
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/inotify-dir-recreate is now passing!

@ChrisDryden ChrisDryden mentioned this pull request Dec 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stdbuf implementation via spawning is incompatible with coreutils

2 participants

@Ecordonnier @oech3