nohup: added a bunch of nohup fixes based on the failures in the GNU tests #9628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
316faef to
f8ddc57
Compare
CodSpeed Performance ReportMerging #9628 will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
ChrisDryden
commented
Dec 10, 2025
|
GNU testsuite comparison: |
f8ddc57 to
3dd84fa
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Dec 13, 2025
|
GNU testsuite comparison: |
Collaborator
Author
|
I'm going to try and split this up into many smaller PR's to make it easier to review. |
This was referenced Dec 17, 2025
Collaborator
Author
sylvestre
reviewed
Dec 17, 2025
src/uu/nohup/src/nohup.rs
Outdated
| let exit_code = failure_code(); | ||
|
|
||
| match open_nohup_file(Path::new(NOHUP_OUT)) { | ||
| Ok(t) => Ok((t, NOHUP_OUT.to_string())), |
Contributor
There was a problem hiding this comment.
maybe
Suggested change
| Ok(t) => Ok((t, NOHUP_OUT.to_string())), | |
| Ok(t) => Ok((t, NOHUP_OUT.to_owned())), |
sylvestre
reviewed
Dec 17, 2025
src/uu/nohup/src/nohup.rs
Outdated
| e2, | ||
| ) | ||
| .into()), | ||
| let homeout_str = homeout.to_str().unwrap().to_string(); |
Contributor
There was a problem hiding this comment.
as ride along, maybe remove the unwrap()
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a bigger PR but the original goal was to try and add the support of always setting the umask of the output file and when running the tests against the GNU tests I found a few inconsistencies that I'm going to summarize below:
First is that the GNU implementation will always try to set umask of nohop.out to 600 which we werent doing in our tests, I added a wrapper to it to make it always set that way.
Second the error message is based on whether the input or/and the output terminal is a terminal, the current implementation printed the same error message for all use cases and I added error messages specific to each use case.
Third, the error code for failure is set based on the ENV variable POSIXLY_CORRECT which we were already doing in some cases but we need to do that for all cases where it would return a 125 failure
Lastly the show_error macro didn't work for this use case because its possible to fail the output to stdout and then its expected to give a different error code based on whether the stderr was written successfully.
I added rust integ tests for each of these scenarios too, the way the tests are set up in nohup is a bit all over the place, when this gets merged in I'd like to make them all use the same macros and reduce the verbosity a bit
This PR has been broken into some smaller PR's to make this PR easier to review: #9684 and #9685