Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add more Cygwin support #9686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
500-internal-server-error wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add more Cygwin support #9686

500-internal-server-error wants to merge 7 commits into from

Conversation

@500-internal-server-error
Copy link

@500-internal-server-error 500-internal-server-error commented Dec 17, 2025

Makes more things compile on Cygwin. Basically a continuation of #9535. This requires a pending PR to nix, and after that some packages need to be updated to allow it to compile out of the box on Cygwin.

@500-internal-server-error 500-internal-server-error marked this pull request as draft December 17, 2025 16:56
@oech3
Copy link
Contributor

oech3 commented Dec 17, 2025 •
edited
Loading

You don't need to care about uname -s since MSYS2 overrides OS.

@500-internal-server-error
Copy link
Author

500-internal-server-error commented Dec 17, 2025

You don't need to care about uname -s since MSYS2 overrides OS.

I don't think so, it still carries the Windows default "Windows_NT", at least on my machine. I need some way to tell apart native Windows and Cygwin.

@500-internal-server-error
Copy link
Author

500-internal-server-error commented Dec 17, 2025

Hmm, not sure why style is failing, I've already formatted the pieces I touched. Will format again anyway.

@oech3
Copy link
Contributor

oech3 commented Dec 17, 2025

MSYS package builds fine without make OS=.... Do you use non-MSYS cygwin?

@oech3
Copy link
Contributor

oech3 commented Dec 17, 2025

Oh sorry. You are right. Cygwin is not Windows_NT...

@500-internal-server-error
Copy link
Author

500-internal-server-error commented Dec 17, 2025

MSYS package builds fine without make OS=.... Do you use non-MSYS cygwin?

It does build fine, but that's because it skips UNIX_PROGS. Since $(OS) == Windows_NT, it assumes not Unix, even though Cygwin should be treated as Unix.

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@oech3

This comment was marked as resolved.

Sign in to view
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@500-internal-server-error
Copy link
Author

500-internal-server-error commented Dec 18, 2025

Hmm network failures...

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@500-internal-server-error @oech3