dd: use seek for stdin skip when possible#9821
Merged
sylvestre merged 4 commits intouutils:mainfrom Jan 13, 2026
Merged
Conversation
|
GNU testsuite comparison: |
asder8215
reviewed
Dec 24, 2025
Contributor
|
can we have a test in rust too? thanks |
|
GNU testsuite comparison: |
2eab198 to
55355dc
Compare
|
GNU testsuite comparison: |
55355dc to
0209293
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Dec 30, 2025
sylvestre
reviewed
Dec 30, 2025
sylvestre
reviewed
Dec 30, 2025
sylvestre
reviewed
Dec 30, 2025
|
GNU testsuite comparison: |
8e24e25 to
ddf7a41
Compare
|
GNU testsuite comparison: |
ddf7a41 to
27d05cb
Compare
|
GNU testsuite comparison: |
mattsu2020
pushed a commit
to mattsu2020/coreutils
that referenced
this pull request
Jan 23, 2026
* dd: use seek for stdin skip when possible * Add Rust tests for skip with seekable stdin * Address review comments: fix return value, add comment, refactor tests * dd: use ibs-sized buffer for ESPIPE fallback in skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dd/skip-seek-past-file test is checking that the default implementation uses skip as the reader by putting a set of inputs that would cause an out of bounds read if skip was not used, but for things like pipe inputs using copy is the right approach to use and we have other GNU tests that rely on that behaviour. This PR uses skip as the default then falls back to copy.