Don't change priority of autop filters #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wordpress adds these filters by default, in the correct order to make sure that rendered shortcodes don't get unwanted tags added to them. Note that the "content" of shortcodes isn't excluded and will still get these tags where appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the wpautop filter where it wouldn't be normally used, or changing its priority, will causes extraneous paragraph and line break tags to be inserted into already rendered elements from plugins, etc. leading to breakage in unpredictable ways, see #78
Wordpress adds these filters by default, in the correct order to make sure that rendered elements don't get unwanted tags added to them. Note that the "content" of shortcodes isn't excluded and will still get these tags where appropriate.
This just returns the UW theme to using that default filtering. I wasn't able to see any change in the appearance of the UW shortcodes.