Add declarations for def instructions (except procedure parameters and global variables) #1163
Conversation
bcd0fb7 to
1491e2d
Compare
…d global variables)
1491e2d to
9ac7d6b
Compare
uxmal
left a comment
There was a problem hiding this comment.
I see a lot of fp leaks. What is your opinion here. Ideally, once all escaped frame accesses have been taken care of, there should be no more fp references in generated code.
| // Return size: 0 | ||
| void fn00100000() | ||
| fn00100000_entry: | ||
| ptr32 fp |
There was a problem hiding this comment.
Should the pseudoregister FramePointer be excluded?
There was a problem hiding this comment.
I think, it's OK. fp variable is used in followed code. So it should be declared.
| // 00008334: void _start(Stack int32 dwArg00, Stack (ptr32 Eq_n) ptrArg08, Stack (ptr32 Eq_n) ptrArg0C, Stack (ptr32 void) ptrArg10) | ||
| void _start(int32 dwArg00, void (* ptrArg08)(), void (* ptrArg0C)(), void * ptrArg10) | ||
| { | ||
| ptr32 fp; |
There was a problem hiding this comment.
This fp is there because of the fp + 4 on the next line, right? Hopefully that will go away when fp + 4 is replaced with &tArg04
There was a problem hiding this comment.
Yes it should go away when fp + 4 is replaced with &tArg04
|
Ideally, it should be no |
|
We'll go with this. The changes in |
No description provided.